Ryan on WordPress

We committed the beginnings of the Image Uploader, brought to you by Andy.

Go get the scoop from Andy.  We committed this last night.  Tired of Kubrick blue?  Clicky-clicky now it’s red.

Thanks to Mark post preview is much spiffier. After you save a draft, you get a full preview of what it will actually look like on your site. Here’s a peek.

I just committed a change to how we populate roles during upgrade. The old way made adding new capabilities to existing roles a pain. The new way handles this nicely and is much easier on the eyes. Furthermore, it actually makes use of our role/cap API instead of going under the covers. What a concept, using our own API.

Give the changeset a look to make sure I didn’t leave out or mangle any caps.

With the commit for bug 1674, we now run kses against post content for users that do not have the ‘unfiltered_html’ capability. By default, only the Administrator and Editor roles have the unfiltered_html capability. Users without that capability with have their posts filtered by kses for some added security.

We need a bug day on IRC where we triage the tracker and bump off as many bugs as we can.  We have some bugs that are already fixed, some that shouldn’t be fixed, some that have almost-there patches, some that need discussion, and some that are incomprehensible.  I’d like to go down the list of bugs and make as many determinations as we can.  Hopefully we can match bugs with people willing to fix them.

Maybe we could do this after one of the Wednesday Meetups.

Courtesy of Andy we have some new comment creation functions.

• wp_insert_comment() - Add a new comment to the DB
• wp_update_comment() - Update an existing comment in the DB
• wp_filter_comment() - Filter comment data
• wp_allow_comment() - Perform various spam checks on a comment

This is in addition to the already existing wp_new_comment(). The extra functions allow importers to skip spam checks and comment notifications when importing comments. The new functions are already being put to use in the Blogger importer.

We had two copies of the edit link form that were only trivially different.  One lived in link-add.php and the other in link-manager.php.  These two copies are now consolidated in edit-link-form.php.  Knock about 200 lines off our TLOC.

I moved most of the link management code into functions. Here’s what we have:

• get_link() - Fetches a link object from the DB
• get_link_to_edit() - Fetches link object and formats fields for editing
• add_link() - Creates a new link from form POST data
• edit_link() - Updates an existing link with data from POST
• wp_insert_link() - Creates a new link in the DB
• wp_update_link() - Updates an existing link in the DB
• wp_delete_link() - Deletes a link from the DB

The code to change visibilty and set attributes for all links in a category needs to be broken out as well.

Link categories need a similar treatment.

How are the new rewrite rules in 1.6 working for everyone? We’ve been running with them for months now and haven’t received any bugs about them for some time.

1.6 adds a minimal set of rewrite rules to htaccess. These rules pass on the rewrite duty to WP itself. Here’s an example of what they look like:

RewriteEngine On
RewriteBase /
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule . /index.php

This is a nice, compact set of rules that has the advantage of not requiring updates whenever a page is added. htaccess needs to be writable only when it is first populated.  WordPress handles rewrite and 404 duties.